legacy: Add vlc handler #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reilly Brogan <[email protected]>
|
@EbonJaeger I've tentatively added you as a reviewer, given your C experience. |
EbonJaeger
requested changes
May 14, 2024
| /** | ||
| * Create a VLC plugin cache | ||
| */ | ||
| static UscHandlerStatus usc_handler_vlc_exec(__usc_unused__ UscContext *ctx, const char *path) |
There was a problem hiding this comment.
ctx does appear to actually be used.
Suggested change
| static UscHandlerStatus usc_handler_vlc_exec(__usc_unused__ UscContext *ctx, const char *path) | |
| static UscHandlerStatus usc_handler_vlc_exec(UscContext *ctx, const char *path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we're not yet migrated to the go usysconf we might as well add a VLC plugins cache since we're using VLC as the phonon provider on Plasma.