Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 macros #22

Closed
wants to merge 1 commit into from
Closed

Qt6 macros #22

wants to merge 1 commit into from

Conversation

Girtablulu
Copy link
Contributor

For the new QT6 packages, some have special user facing tools text which tells us which bin should a user be able to use.

I merged the normal ninja_install path into the function

@JoshStrobl
Copy link
Member

If you're providing the marcos, who is going to provide the polos? 🤔

@Girtablulu
Copy link
Contributor Author

@JoshStrobl ....... I need a slap function on github

@Girtablulu Girtablulu changed the title Qt6 marcos Qt6 macros Oct 9, 2021
Comment on lines +41 to +43
while read _line; do
ln -s $_line
done < %workdir%/solusBuildDir/user_facing_tool_links.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the purpose of this / provide a real world example?

@Girtablulu
Copy link
Contributor Author

With Qt6 only certain tools needs to be user facing which are getting mentioned inside this file, so instead of manually symlink them we just call the file for these.

file content

/usr/lib64/qt6/bin/qmake usr/bin/qmake6

@ReillyBrogan
Copy link
Contributor

Note that I merged the qml6_cache macro separately as the need for that is quite obvious. I'm unsure what the first macro is used for, so I'll leave that as-is for now.

@ermo
Copy link
Contributor

ermo commented Dec 4, 2023

Note that I merged the qml6_cache macro separately as the need for that is quite obvious. I'm unsure what the first macro is used for, so I'll leave that as-is for now.

@Girtablulu I don't suppose you could provide some insight here (assuming you can find the time)?

@ermo
Copy link
Contributor

ermo commented May 3, 2024

@Girtablulu ping? Can you give some context for this? You can also just close it if you don't feel it's relevant any more.

Thanks.

@ermo
Copy link
Contributor

ermo commented Oct 25, 2024

If this was to be merged, it would have been merged already, given we have been on Qt6 for a while now.

@ermo ermo closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants