Fix most of the typing errors in datastore.py #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use the _Element/_ElementTree class instead of the Element/ElementTree factory for typing - expect None values returned by lxml - expect None values in case the methods are used in the wrong order - fix the use of undefined variables in do_first_run_versioning - other minor typing fixes
|
LGTM, thanks! Will make a note to look at that function too |
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
diegogangl
added
enhancement
maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are the following:
_Element/_ElementTreeclass instead of theElement/ElementTreefactory for typing,Nonevalues returned by lxml,Nonevalues in case the methods are used in the wrong order,do_first_run_versioning.(Please note that
do_first_run_versioningis never called. Maybe it is a bug or something to be removed.)