Use Task.set_status to mark tasks as dismissed #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Task.toggle_dismiss caused the task to reactivate if it was already dismissed. (E.g., when selecting and dismissing deeply nested task structures.)
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Works as expected, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #1183.
Calling
Task.toggle_dismisscaused the task to reactivate if it was already dismissed.Steps to reproduce the bug:
Note: While debugging, I noticed that certain tasks are dismissed multiple times since they are selected and they are descendants of other tasks.