Address review notes

gevtushenko · May 25, 2023 · e1f501c · e1f501c
1 parent 61f0b10
commit e1f501c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/cub/agent/single_pass_scan_operators.cuh b/cub/agent/single_pass_scan_operators.cuh
@@ -782,14 +782,11 @@ struct TilePrefixCallbackOp
         , tile_idx(tile_idx)
     {}
 
-    // Computes the tile index and constructs prefix functor with it. 
+    // Computes the tile index and constructs prefix functor with it.
     __device__ __forceinline__ TilePrefixCallbackOp(ScanTileStateT &tile_status,
                                                     TempStorage &temp_storage,
                                                     ScanOpT scan_op)
-        : temp_storage(temp_storage.Alias())
-        , tile_status(tile_status)
-        , scan_op(scan_op)
-        , tile_idx(blockIdx.x)
+        : TilePrefixCallbackOp(tile_status, temp_storage, scan_op, blockIdx.x)
     {}
 
     // Block until all predecessors within the warp-wide window have non-invalid status
@@ -887,7 +884,7 @@ struct TilePrefixCallbackOp
     }
 
     __device__ __forceinline__
-    int GetTileIdx()
+    int GetTileIdx() const
     {
         return tile_idx;
     }

diff --git a/examples/device/example_device_decoupled_look_back.cu b/examples/device/example_device_decoupled_look_back.cu
@@ -103,13 +103,10 @@ void decoupled_look_back_example(int blocks_in_grid)
   // Initialize temporary storage
   scan_tile_state_t tile_status;
   tile_status.Init(blocks_in_grid, d_temp_storage, temp_storage_bytes);
-
-  {
-    const unsigned int threads_in_init_block = 256;
-    const unsigned int blocks_in_init_grid   = cub::DivideAndRoundUp(blocks_in_grid,
-                                                                   threads_in_init_block);
-    init_kernel<<<blocks_in_init_grid, threads_in_init_block>>>(tile_status, blocks_in_grid);
-  }
+  const unsigned int threads_in_init_block = 256;
+  const unsigned int blocks_in_init_grid   = cub::DivideAndRoundUp(blocks_in_grid,
+                                                                 threads_in_init_block);
+  init_kernel<<<blocks_in_init_grid, threads_in_init_block>>>(tile_status, blocks_in_grid);
 
   // Launch decoupled look-back
   const unsigned int threads_in_block = 256;