[v0.18] Use #[repr(C)] for vertex & constant structs.#3791
Merged
kvark merged 2 commits intogfx-rs:v0.18from Feb 27, 2023
Merged
[v0.18] Use #[repr(C)] for vertex & constant structs.#3791kvark merged 2 commits intogfx-rs:v0.18from
kvark merged 2 commits intogfx-rs:v0.18from
Conversation
Fixes issues with rust 1.67 field ordering.
Contributor
Author
|
Hey @kvark i know v0.18 is ancient these days, but this fix is quite valuable for anyone still using it with rust 1.67 (like me). I think it's worth making a 0.18.3 release with this. Wdyt? |
Member
|
@alexheretic sure, sounds good! |
Member
|
Would you mind bumping the version to 0.18.3 in the PR? |
Contributor
Author
✔️ |
kvark
approved these changes
Feb 27, 2023
Member
|
Published now. Thank you for support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues exposed by rust 1.67 field ordering changes (rust-lang/rust#102750)
This PR adds
#[repr(C)]to vertex & constant structs preventing field ordering issues.Note: This actually still works fine even if users have manually specified
#[repr(C)]themselves since declaring it multiple times works fine, e.g. this works:Resolves #3790
Could we get a new gfx crate release with this in it please? I think this will help out any old-school users of this crate.