Add methods to get raw d3d12::ComPtr<dxgi1_4::IDXGISwapChain3> from DX12 Surface
#5772
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Aug 27, 2024
| @@ -177,6 +177,12 @@ pub struct Surface { | |||
| unsafe impl Send for Surface {} | |||
| unsafe impl Sync for Surface {} | |||
|
|
|||
| impl Surface { | |||
| pub unsafe fn swap_chain(&self) -> Option<d3d12::ComPtr<dxgi1_4::IDXGISwapChain3>> { | |||
There was a problem hiding this comment.
Suggested change
| pub unsafe fn swap_chain(&self) -> Option<d3d12::ComPtr<dxgi1_4::IDXGISwapChain3>> { | |
| pub unsafe fn swapchain(&self) -> Option<d3d12::ComPtr<dxgi1_4::IDXGISwapChain3>> { |
Nit for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows retrieving the
d3d12::ComPtr<dxgi1_4::IDXGISwapChain3>from a DX12Surfaceby cloning the pointer. I'm not sure if there are any conventions around exposing this kind of low-level API, so feel free to comment. I might amend this PR with methods to expose other low-level types if appropriate.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.