WIP: feat: only require depth config. for fmts. w/ depth #6026
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 24, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
|
Corresponding Bugzilla link for Firefox: bug 1910140 |
ErichDonGubler
added
area: api
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Aug 22, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 6, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 6, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 13, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 13, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 15, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 17, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 18, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 23, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 26, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Sep 28, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 10, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
force-pushed
the
require-depth-deets-only-for-depthy-fmts
branch
2 times, most recently
from
a5b3d3a
to
334c0a0
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 16, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 21, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 30, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
force-pushed
the
require-depth-deets-only-for-depthy-fmts
branch
2 times, most recently
from
9a5e366
to
ca1b8b9
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 1, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
force-pushed
the
require-depth-deets-only-for-depthy-fmts
branch
from
ca1b8b9
to
d7e9da9
Compare
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 4, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 5, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 7, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Nov 7, 2024
…teEnabled,depthCompare}` optional r=#webgpu-reviewers! TODO: resolve [`gfx-rs/wgpu`#6026](gfx-rs/wgpu#6026) for consumption
ErichDonGubler
force-pushed
the
require-depth-deets-only-for-depthy-fmts
branch
from
d7e9da9
to
63258de
Compare
TODO: Ensure that the following changes and discussion get represented in code: - https://github.com/gpuweb/gpuweb/pull/4318/files - gpuweb/gpuweb#3905 - https://github.com/gpuweb/gpuweb/pull/3849/files#r1122411287
ErichDonGubler
force-pushed
the
require-depth-deets-only-for-depthy-fmts
branch
from
63258de
to
ca767f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Ensure that the following changes and discussion get represented in code:
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.