Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSL: Implement diagnostic(…); directives and derivative_uniformity triggering rule #6148

Merged
merged 5 commits into from
Nov 12, 2024
Merged

WGSL: Implement diagnostic(…); directives and derivative_uniformity triggering rule #6148

merged 5 commits into from
Nov 12, 2024
+544 −75

Commits on Nov 12, 2024

  1. refactor(wgsl-in): specify more closure ret. types in parsing 

    This resolves ambiguity that will be introduced in the subsequent commit
that adds `impl From<ConflictingDiagnosticRuleError> for naga::Error`.
    @ErichDonGubler
    ErichDonGubler committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2bfeadc View commit details
    Browse the repository at this point in the history

  2. feat(wgsl-in): detect conflicting diag. filters

    @ErichDonGubler
    ErichDonGubler committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    12b0f66 View commit details
    Browse the repository at this point in the history

  3. chore: remove unimpl. diag. filt. err. check

    @ErichDonGubler
    ErichDonGubler committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    407eb76 View commit details
    Browse the repository at this point in the history

  4. refactor(wgsl-in): track diagnostic directives in func. analysis

    @ErichDonGubler
    ErichDonGubler committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1ffd9c2 View commit details
    Browse the repository at this point in the history

  5. feat(wgsl-in): filter unif. analysis errors with derivative_uniformity 

    - Remove `DISABLE_UNIFORMITY_REQ_FOR_FRAGMENT_STAGE`.
- Add `CHANGELOG` entry.
- Add coverage to `naga`'s `valid::analyzer::uniform_control_flow` test.
    @ErichDonGubler
    ErichDonGubler committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3ee9dca View commit details
    Browse the repository at this point in the history