Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: create texture from d3d11 shared handle #6161

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

Vulkan: create texture from d3d11 shared handle #6161

wants to merge 10 commits into from
+202 −63

Conversation

xiaopengli89
Copy link
Contributor

Description
VK_KHR_external_memory_win32 extension enables application to import Vulkan memory objects from Windows handles.

Testing

  1. Create D3D11 texture with D3D11_RESOURCE_MISC_SHARED_NTHANDLE and D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX flags
  2. Create shared handle with IDXGIResource1::CreateSharedHandle
  3. Create vulkan texture with texture_from_d3d11_shared_handle

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@xiaopengli89 xiaopengli89 requested a review from a team as a code owner August 26, 2024 07:39
@xiaopengli89 xiaopengli89 force-pushed the vulkan-texture-from-d3d11-shared-handle branch 3 times, most recently from 989df37 to c9f009e Compare August 27, 2024 10:04
cwfitzgerald
cwfitzgerald requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some comments

wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
wgpu-hal/src/vulkan/device.rs Show resolved Hide resolved
wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
@xiaopengli89 xiaopengli89 force-pushed the vulkan-texture-from-d3d11-shared-handle branch from 2ce979b to e2edab2 Compare August 28, 2024 07:09
@xiaopengli89 xiaopengli89 force-pushed the vulkan-texture-from-d3d11-shared-handle branch 5 times, most recently from 1563ef2 to 4ebcdb3 Compare August 30, 2024 12:02
@xiaopengli89 xiaopengli89 changed the title Vulkan: create texture from d3d11 shared handle WIP: Vulkan: create texture from d3d11 shared handle Sep 3, 2024
@xiaopengli89 xiaopengli89 changed the title WIP: Vulkan: create texture from d3d11 shared handle Vulkan: create texture from d3d11 shared handle Sep 3, 2024
@xiaopengli89 xiaopengli89 force-pushed the vulkan-texture-from-d3d11-shared-handle branch 3 times, most recently from d221534 to 6e1d7c6 Compare September 6, 2024 07:49
@AdrianEddy AdrianEddy mentioned this pull request Sep 6, 2024
Closed
@xiaopengli89 xiaopengli89 force-pushed the vulkan-texture-from-d3d11-shared-handle branch 4 times, most recently from 054729c to a0a89e4 Compare September 12, 2024 05:18
@xiaopengli89 xiaopengli89 force-pushed the vulkan-texture-from-d3d11-shared-handle branch from a0a89e4 to b55c0ba Compare September 13, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 Awaiting requested review from MarijnS95

@cwfitzgerald cwfitzgerald Awaiting requested review from cwfitzgerald

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaopengli89 @MarijnS95 @cwfitzgerald