-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[naga msl-out] Implement atomicCompareExchangeWeak for MSL backend #6265
[naga msl-out] Implement atomicCompareExchangeWeak for MSL backend #6265
Conversation
See also #5675 |
@jimblandy I understand that @9291Sam opened another similar PR, but the progress seems a bit slow. Since this branch is for my own project, I was hoping for quicker updates. That's why I decided to contribute. |
Oh, definitely. I think we should probably review this PR instead. I just wanted to have the linkage there so that people could find the relationship if they wanted. |
b42d236
to
37b2c93
Compare
@jimblandy I understand. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@AsherJingkongChen this needs a rebase + updating the msl snapshots due to #6285. |
37b2c93
to
31548e2
Compare
…com/AsherJingkongChen/wgpu into pr/naga/msl/atomic-compare-exchange
@teoxoy I had not squashed commits, would it matter? I see it was auto-squashed. |
I squashed them when I merged the PR (see bf33e48). |
Connections
Fixes #5257 and #4364 (partially).
Closes #5675.
Description
Implement
atomicCompareExchangeWeak
for MSL (Metal) backend.Please see Metal Specification 2024-06-06, Page 249 for support details.
Testing
I enabled and validated 2 snapshots for Metal.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.