Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wgsl-in): parse diagnostic(…) attributes on fns #6353

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Oct 1, 2024

Connections

Description

Building on #6148 and #6533, we use all the plumbing we made for tracking diagnostic rules, and add a (successful) parse path for @diagnostic(…) fn function() { … }. This and #6148's parse paths are what I've observed to be the next most common places for users to apply diagnostic filtering, by a wide margin. I expect we will

Testing

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch from bf4eab8 to a954d89 Compare October 3, 2024 20:25
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 11 times, most recently from 3039803 to 6479c1d Compare October 18, 2024 16:40
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 14 times, most recently from 9b6f777 to 319229a Compare October 25, 2024 18:32
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 2 times, most recently from 05f8ba6 to 8a3e747 Compare October 26, 2024 01:10
@ErichDonGubler ErichDonGubler self-assigned this Oct 29, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 6 times, most recently from b77694d to 45fb2e5 Compare November 13, 2024 17:09
@ErichDonGubler

This comment was marked as resolved.

@ErichDonGubler ErichDonGubler marked this pull request as ready for review November 13, 2024 17:10
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner November 13, 2024 17:10
@ErichDonGubler ErichDonGubler added type: enhancement New feature or request naga Shader Translator area: naga middle-end Intermediate representation area: naga front-end lang: WGSL WebGPU Shading Language area: naga processing Passes over IR in the middle labels Nov 13, 2024
@ErichDonGubler ErichDonGubler changed the title Parse diagnostic(…) attributes on fns feat(wgsl-in): parse diagnostic(…) attributes on fns Nov 13, 2024
@ErichDonGubler
Copy link
Member Author

Populated the OP with test results.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErichDonGubler ErichDonGubler merged commit 92ca5a3 into gfx-rs:trunk Nov 15, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler/push-xlypklnukzlu branch November 15, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: naga front-end area: naga middle-end Intermediate representation area: naga processing Passes over IR in the middle lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support diagnostic filters in WGSL (i.e., diagnostic(…))
2 participants