Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mesh shading api to wgpu & wgpu-core #7345

Draft
wants to merge 28 commits into
base: trunk
Choose a base branch
from

Conversation

SupaMaggie70Incorporated
Copy link
Contributor

@SupaMaggie70Incorporated SupaMaggie70Incorporated commented Mar 15, 2025

Connections
#7197

Description
Adds a mesh shading api to wgpu and wgpu-core so that further tests/examples/progress can be made.

This is a rather large PR. If it needs to be split up, I suppose that could be done, but the individual parts all kind of interact. Also doesn't help that I've never tried to split up a branch/PR.

Remaining work is all in limits. There are a lot of limits in https://registry.khronos.org/vulkan/specs/latest/man/html/VkPhysicalDeviceMeshShaderPropertiesEXT.html, many of which will be relevant, though plenty of it for naga. I will only try to use the limits we currently need for validation, rather than try to guess which will be useful.

Testing
This change currently has several tests plus an example.

Squash or Rebase?

Not sure about this honestly, due to inexperience with git.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@SupaMaggie70Incorporated SupaMaggie70Incorporated marked this pull request as ready for review March 16, 2025 04:07
@SupaMaggie70Incorporated SupaMaggie70Incorporated requested a review from a team as a code owner March 16, 2025 04:07
@SupaMaggie70Incorporated SupaMaggie70Incorporated marked this pull request as draft March 16, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant