-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mesh shading api to wgpu & wgpu-core #7345
Draft
SupaMaggie70Incorporated
wants to merge
28
commits into
gfx-rs:trunk
Choose a base branch
from
SupaMaggie70Incorporated:mesh-shading/wgpu-api
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add mesh shading api to wgpu & wgpu-core #7345
SupaMaggie70Incorporated
wants to merge
28
commits into
gfx-rs:trunk
from
SupaMaggie70Incorporated:mesh-shading/wgpu-api
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
…moved accidentally commited test-output.txt
… also broken, just trying to get CI to report compile errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#7197
Description
Adds a mesh shading api to wgpu and wgpu-core so that further tests/examples/progress can be made.
This is a rather large PR. If it needs to be split up, I suppose that could be done, but the individual parts all kind of interact. Also doesn't help that I've never tried to split up a branch/PR.
Remaining work is all in limits. There are a lot of limits in https://registry.khronos.org/vulkan/specs/latest/man/html/VkPhysicalDeviceMeshShaderPropertiesEXT.html, many of which will be relevant, though plenty of it for naga. I will only try to use the limits we currently need for validation, rather than try to guess which will be useful.
Testing
This change currently has several tests plus an example.
Squash or Rebase?
Not sure about this honestly, due to inexperience with git.
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.