Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted D3D12 suballocation cleanups #7476

Merged
merged 9 commits into from
Apr 7, 2025

Conversation

cwfitzgerald
Copy link
Member

Connections

Part of my work on #4150.

Description

This PR solves two problems:

  • After using the suballocation module in anger, I realized there was quite a lot of excess cruft from an older design. This cleans it up and tries to simplify the API.
  • This enables me to create buffers from the command encoder, which is something I need for [d3d12] Support non-default rows_per_image #4150.

Each commit is standalone and the review experience is commit-by-commit.

Testing

CI.

Squash or Rebase?

Rebase vibes.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner April 3, 2025 22:51
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@teoxoy teoxoy merged commit 46ef1fc into gfx-rs:trunk Apr 7, 2025
37 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/assorted-d3d12-cleanup branch April 7, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants