(Naga) Add support for Storage Image Multisample when ingesting SPIR-V #8270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasenbanck
force-pushed
the
naga-ms-textures
branch
from
4b88038 to
9b2a9c9
Compare
Naga seems to support StorageImageMultisample just fine. The snapshot test I added shows that the correct WGSL is created. Fixes gfx-rs#8269
hasenbanck
force-pushed
the
naga-ms-textures
branch
from
9b2a9c9 to
5b5a794
Compare
cwfitzgerald
approved these changes
Sep 29, 2025
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Having tests here is amazing, makes me fully confident in just merging this!
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8269
Description
Naga seems to support StorageImageMultisample just fine. The snapshot test I added shows that the correct WGSL is created.
Testing
Shnapshottest and also verified it working in our open source game engine.
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.