Validate storage texture formats when creating BGLs #8735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleiserson
commented
Dec 15, 2025
teoxoy
reviewed
Dec 16, 2025
Member
teoxoy
left a comment
teoxoy
left a comment
There was a problem hiding this comment.
The spec doesn't seem to require validating this twice. The format is validated when creating the BGL and when creating the BG, the format of the view is checked against the format of the BGL entry.
This moves existing validation from binding creation to BGL creation. Binding creation already had a check that returns `CreateBindGroupError::InvalidStorageTextureFormat` if the format does not match the layout, so it is not necessary to revalidate the format support at that point.
andyleiserson
force-pushed
the
push-wllqoxxtontv
branch
from
9bc68c6 to
e0e3181
Compare
Contributor
Author
|
Updated to validate format support only on BGL creation. The existing check in binding creation that the format matches the layout remains. |
teoxoy
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were validating storage texture compatibility when creating bindings, not when creating BGLs, which is when the spec calls for it. Move the existing validation to BGL creation. binding creation already checked that the format matches the layout, so we don't need to re-validate the format when the binding is created.
I omitted a changelog entry since it seems unlikely that anybody could be accomplishing anything useful by creating such BGLs and not binding them, but, I'd be happy to add one if it seems appropriate. (Not specific to this change, but in general, stricter validation seems likely to break things and thus worth noting in the change log. On the other hand, we have a lot of missing validation so noting absolutely every change to validation could bloat the changelog quite a bit.)
Testing
By the CTS.
Squash or Rebase? Squash
Checklist
CHANGELOG.mdentry.