Mesh shader HLSL writer #8752
Open
Mesh shader HLSL writer #8752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Inner Daemons <[email protected]>
Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
requested changes
Jan 15, 2026
Comment on lines
+102
to
+103
| @mesh(mesh_output) @workgroup_size(2, 1, 1) | ||
| fn ms_divergent(@builtin(local_invocation_id) thread_id_1: vec3<u32>) { |
Collaborator
Author
There was a problem hiding this comment.
Our HLSL writer has a bug where it doesn't consider the local_invocation_index being written by the zero-initializer/mesh shader output loop to be a builtin. So I had to use an alternative here, since local_invocation_index was being used elsewhere
Co-authored-by: Connor Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of #7197
Closes #7219
Related to #8739
Depends on #8756
Description
Adds support for mesh shaders to HLSL writer. There still exist some things to do:
Limit dispatched workgroup countsOnly expose mesh shader feature on DX12 if DXC with shader model is supportedRequire shader model 6.5 in nagaChangelog entryTesting
Existing tests, snapshots
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.