Remove maxInterStageShaderComponents
#8761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
changed the title
maxInterStageShaderVariables
ErichDonGubler
changed the title
maxInterStageShaderVariablesmaxInterStageShaderComponents
TODO: split movement of `enum` mapping out TODO: explain - Prep for a new `enum` later, `naga::ShaderStage` is the closest thing.
ErichDonGubler
force-pushed
the
remove-max_inter_stage_shader_components
branch
from
b2cea56 to
803112b
Compare
…lidation` TODO: explain - bundle state needed into same place - Discovery: `compare_function` was being provided, but not checked, in other places. Intentional?
…tion (minus `clip-distances`) Notable public API additions: - New `StageError` variants: - `VertexOutputLocationTooLarge` - `TooManyVertexOutputs` - Add new `shader_io_deductions` submodule of `wgpu_core::validation` with: - A `ShaderIoDeduction` trait - `enum MaxVertexShaderOutputDeduction` - `MaxInterStageShaderVariablesDeductions` for them.
ErichDonGubler
force-pushed
the
remove-max_inter_stage_shader_components
branch
from
803112b to
6ad65f9
Compare
ErichDonGubler
force-pushed
the
remove-max_inter_stage_shader_components
branch
from
6ad65f9 to
49959f1
Compare
Member
Author
|
Folding this into #8761. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
maxInterStageShaderComponentstomaxInterStageShaderVariables(minus coverage ofclip-distances) #8652.maxInterStageShaderVariableswas originally discussed for introduction to the WebGPU spec. committee at Should we constrain the location of user input-output stage variables WGSL gpuweb/gpuweb#1962.maxInterStageShaderVariableswas proposed to outright supersedemaxInterStageShaderComponentswith maxInterStageShaderComponents seems to overlap with maxInterStageShaderVariables gpuweb/gpuweb#4688.Testing
Since we're removing functionality, I don't think we need new coverage here.
Squash or Rebase?
Rebase.