Ensure symlinked target directory is ignored. #8796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the trailing slash it will not ignore 'target' if it is a symlink. By removing that symlinked 'target' directories are correctly ignored. The slash at the start ensures that it will not ignore directories called 'target' that may be created in the future that aren't at the root of the repository. This change aligns with the default .gitignore from `cargo init`. Originally discussed in gfx-rs#8795 (comment)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Originally proposed and discussed in #8795 (comment) with @ErichDonGubler and @inner-daemons , where the consensus was that this change would warrant its own PR.
Description
Commit message:
I confirmed that using
/targetis still the default ignore in today's master branch for Cargo.Testing
Prior to touching the
.gitignore, thetargetsymlink at the root of my repository was marked as dirty, after this commit it is properly ignored and no longer marked as dirty and available for staging.Squash or Rebase?
Single commit, so shouldn't matter.
Checklist
cargo fmt.taplo format. -> Don't have this installed, shouldn't matter.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknown-> NAcargo xtask testto run tests. -> Don't have this installed, shouldn't matter.CHANGELOG.mdentry. -> No user facing changes.