Invalidate instead of flushing the mapped range when reading back BLAS compacted size. #8838
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Noticed while looking for the cause of #8825 , but this is not a fix for it.
Description
Previously, if the buffer mapping for a given BLAS's compact readback buffer was non-coherent (I want to say incoherent but I think that's wrong) it would call
device.flush_mapped_ranges.flush_mapped_rangesis meant for CPU -> GPU writes, but this is a readback buffer, so it does a GPU -> CPU read and so needsinvalidate_mapped_rangesinstead.Testing
I don't think my computers return non-coherent mappings, so probably none.
Squash or Rebase?
Squash
Checklist
cargo fmt.cargo clippy --tests. If applicable, add:cargo xtask testto run tests.CHANGELOG.mdentry.