Skip to content

Conversation

@Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Jan 7, 2026

Connections
Noticed while looking for the cause of #8825 , but this is not a fix for it.

Description
Previously, if the buffer mapping for a given BLAS's compact readback buffer was non-coherent (I want to say incoherent but I think that's wrong) it would call device.flush_mapped_ranges. flush_mapped_ranges is meant for CPU -> GPU writes, but this is a readback buffer, so it does a GPU -> CPU read and so needs invalidate_mapped_ranges instead.

Testing
I don't think my computers return non-coherent mappings, so probably none.

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run cargo clippy --tests. If applicable, add:
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@Vecvec Vecvec force-pushed the fix-incoherent-compact-readback branch from 656ccda to fc8ef39 Compare January 8, 2026 22:19
@cwfitzgerald cwfitzgerald self-assigned this Jan 14, 2026
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@cwfitzgerald cwfitzgerald merged commit bdc8f61 into gfx-rs:trunk Jan 15, 2026
51 of 52 checks passed
@cwfitzgerald cwfitzgerald deleted the fix-incoherent-compact-readback branch January 15, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants