Round max_vertex_buffer_array_stride down to a multiple of 4 #8847
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gfx-rs#8846 Note that the CTS test in the issue is already enabled (`webgpu:api,operation,vertex_state,correctness:non_zero_array_stride_and_attribute_offset:*`). It seems the failure only appears on specific hardware/drivers.
|
Tested the PR and it does fix #8846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #8846 using the same strategy as #8719, which fixed a similar problem with storage binding size alignment.
Note that the CTS test in the issue is already enabled (
webgpu:api,operation,vertex_state,correctness:non_zero_array_stride_and_attribute_offset:*). It seems the failure only appears on specific hardware/drivers.Testing
Untested
Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.