tests: disable GGUF test for bad value size #10886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10830 (comment) .
This PR makes the test failure with a bad value size deterministic (as in independent of the seed). The way this test causes a failure is not really well-defined since it just writes a random wrong number of wrong, random bytes to the file. So depending on the RNG you can get a random, uncaught failure in a
calloc
call. This PR makes the test failure deterministic to prevent false positives in the CI until I have the C++ refactor ready.@ggerganov where in llama.cpp is the sanitizer logic defined? I usually use Valgrind for my local development but I'd like to assert that there aren't any more random failures with the method used in the CI.