Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama : refactor src/llama.cpp #10902

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

llama : refactor src/llama.cpp #10902

wants to merge 1 commit into from

Conversation

ggerganov
Copy link
Owner

Attempting to split the src/llama.cpp into a few separate modules. Very work-in-progress, mainly opening this PR for people to keep track and suggest improvements as we move along. This part does not involve functional changes, just code reorganization and decoupling to make it easier to work with the codebase. The batch and KV cache abstractions and reimplementations will be done in follow-up PRs.

graph TD;
model   --> arch;
model   --> vocab;
model   --> mmap;
context --> batch;
context --> model;
context --> kv_cache;
context --> control_vector;
Loading

@ngxson
Copy link
Collaborator

ngxson commented Dec 19, 2024

I think control_vector and lora related stuff should be re-grouped into a module, maybe called adapters (if someone has a better naming, feel free to comment). That's because they work kinda the same way, by "adding things" on top of the original cgraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants