Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: build fixes for 32b #10927

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vulkan: build fixes for 32b #10927

wants to merge 2 commits into from

Conversation

jeffbolznv
Copy link
Collaborator

Should fix #10923

@jeffbolznv jeffbolznv requested a review from 0cc4m December 21, 2024 05:21
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Dec 21, 2024
@jeffbolznv jeffbolznv mentioned this pull request Dec 21, 2024
Open
@ggerganov
Copy link
Owner

The ggml-ci has been reporting "maybe uninitialized" warnings for a while:

https://github.com/ggml-org/ci/blob/31168d7a582ded11a0dec489a62fb8bef74349a8/llama.cpp/a9/1a41364b25705dbb81ae996bc35c3440c63b35/ggml-6-x86-vulkan-t4/stdall#L538

Might want to fix these too.

@jeffbolznv
Copy link
Collaborator Author

Second commit ought to fix the uninitialized variables, though I couldn't reproduce the warnings/errors locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m Awaiting requested review from 0cc4m

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile bug: macOS Vulkan build fails
2 participants
@jeffbolznv @ggerganov