Skip to content

CUDA: update compilation flags for improved performance #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CUDA: update compilation flags for improved performance #1099

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a9dc3e
CUDA: update compilation flags for improved performance
royshil Feb 3, 2025
9172f86
CMake: add option for CUDA compile threads and update flags
royshil Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ggml-cuda/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ if (CUDAToolkit_FOUND)

set(CUDA_CXX_FLAGS "")

set(CUDA_FLAGS -use_fast_math)
set(CUDA_FLAGS -use_fast_math --threads=0 --split-compile=0)
Copy link
Contributor

@WilliamTambellini WilliamTambellini Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we better create a new cmake option: eg CUDA_COMPILE_THREADS ?

Copy link
Author

@royshil royshil Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea thats an easy fix. let me do that


if (GGML_FATAL_WARNINGS)
list(APPEND CUDA_FLAGS -Werror all-warnings)
Expand Down