Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CANN: Refactor to reduce duplicate code #12731

Merged
merged 2 commits into from
Apr 7, 2025
Merged

CANN: Refactor to reduce duplicate code #12731

merged 2 commits into from
Apr 7, 2025

Conversation

hipudding
Copy link
Collaborator

@hipudding hipudding commented Apr 3, 2025 •
edited
Loading

Make sure to read the contributing guidelines before submitting a PR

Refactor to reduce duplicate code

@hipudding hipudding self-assigned this Apr 3, 2025
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Apr 3, 2025
noemotiovon
noemotiovon reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@noemotiovon noemotiovon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀This is an outstanding contribution! It significantly reduces redundant code. There are a few minor suggestions.

@hipudding hipudding added the Ascend NPU issues specific to Ascend NPUs label Apr 7, 2025
@hipudding hipudding marked this pull request as ready for review April 7, 2025 03:24
@hipudding hipudding requested review from ggerganov and slaren April 7, 2025 03:39
@hipudding
Copy link
Collaborator Author

The source of openEuler OS is not stable these days. I have tested this PR in my local environment.

@hipudding hipudding merged commit d0d5b22 into ggml-org:master Apr 7, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

@noemotiovon noemotiovon noemotiovon approved these changes

@ggerganov ggerganov Awaiting requested review from ggerganov

Assignees

@hipudding hipudding

Labels
Ascend NPU issues specific to Ascend NPUs ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hipudding @slaren @noemotiovon