-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
17 changed files
with
2,376 additions
and
1,434 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#' Pipe operator | ||
#' | ||
#' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details. | ||
#' | ||
#' @name %>% | ||
#' @rdname pipe | ||
#' @keywords internal | ||
#' @export | ||
#' @importFrom magrittr %>% | ||
#' @usage lhs \%>\% rhs | ||
#' @param lhs A value or the magrittr placeholder. | ||
#' @param rhs A function call using the magrittr semantics. | ||
#' @return The result of calling `rhs(lhs)`. | ||
NULL |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,56 +1,77 @@ | ||
|
||
## Comments | ||
#### 2021-06-20 | ||
#### 2023-11-22 | ||
|
||
I have fixed the failing tests due to an update in `network` package. `GGally` now requires the latest version of the `network` package and should pass the tests. | ||
Thank you for being patient with me on my submission. | ||
|
||
Thank you, | ||
I have fixed the packageVersion issue by removing the unecessary code: https://github.com/ggobi/ggally/commit/9e7228c6d4219c515857426a982d1a5c1ff0cd13 | ||
|
||
The update also contains bug fixes and new datasets. | ||
|
||
Please let me know if there is anything else I can do to help. Thank you again for your patience!! | ||
|
||
Best, | ||
Barret | ||
|
||
#### 2021-06-08 | ||
|
||
Dear maintainer, | ||
#### 2023-11-07 | ||
|
||
Please see the problems shown on | ||
<https://cran.r-project.org/web/checks/check_results_GGally.html>. | ||
Can you please change to "3.3"? | ||
|
||
Please correct before 2021-06-22 to safely retain your package on CRAN. | ||
Please fix before 2023-11-21 to safely retain your package on CRAN. | ||
|
||
Best, | ||
Best | ||
-k | ||
|
||
|
||
#### 2023-07-18 | ||
|
||
[packageVersion() should only compare against strings.] | ||
|
||
.... | ||
|
||
Please correct before 2023-08-16 to safely retain your package on CRAN. | ||
|
||
.... | ||
|
||
Best | ||
-k | ||
|
||
********************************** | ||
|
||
$GGally | ||
$GGally$`GGally/R/gg-plots.R` | ||
$GGally$`GGally/R/gg-plots.R`[[1]] | ||
packageVersion("ggplot2") >= 3.3 | ||
|
||
|
||
|
||
## Test environments and R CMD check results | ||
## R CMD check results | ||
|
||
* local macOS install 11.3.1 | ||
* R 4.0 | ||
* GitHub Actions - https://github.com/ggobi/ggally/pull/419/checks | ||
* macOS, windows, ubuntu {16,20} - R release | ||
* macOS, windows, ubuntu {16,20} - R oldrelease | ||
* 0 errors | 0 warnings | 1 note | ||
|
||
* win-builder | ||
* devel | ||
* release | ||
* oldrelease | ||
Maintainer: ‘Barret Schloerke <[email protected]>’ | ||
|
||
#### R CMD check results | ||
Found the following (possibly) invalid URLs: | ||
URL: https://www.oecd.org/pisa/pisaproducts/database-cbapisa2012.htm | ||
From: man/australia_PISA2012.Rd | ||
Status: 403 | ||
Message: Forbidden | ||
|
||
* 0 errors | 0 warnings | 0 notes | ||
When visiting the link manually, the link works as expected. I believe they have a bot blocker that is causing this error. | ||
|
||
|
||
## revdepcheck results | ||
|
||
We checked 125 reverse dependencies (100 from CRAN + 25 from BioConductor), comparing R CMD check results across CRAN and dev versions of this package. | ||
We checked 158 reverse dependencies (128 from CRAN + 30 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. | ||
|
||
* We saw 0 new problems | ||
* We failed to check 2 packages | ||
* We failed to check 3 packages | ||
|
||
Issues with CRAN packages are summarised below. | ||
|
||
### Failed to check | ||
|
||
* egoTERGM (NA) | ||
* Package is archived. I believe this is a false positive | ||
* loon.ggplot (NA) | ||
* Could not install `loon`. The changes made for this release should have a negative effect on their code. | ||
* fingerPro (NA) - depends on rjags; Could not install rjags | ||
* loon.ggplot (NA) - Trying to attached to a null device | ||
* simmr (NA) - depends on rjags; Could not install rjags |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -175,3 +175,4 @@ Homewood | |
ibb | ||
rbi | ||
sb | ||
magrittr |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.