Skip to content

Commit

Permalink
v2.2.0 (#458)
Browse files Browse the repository at this point in the history
  • Loading branch information
schloerke authored Nov 22, 2023
1 parent 8131749 commit f6cd613
Show file tree
Hide file tree
Showing 17 changed files with 2,376 additions and 1,434 deletions.
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: GGally
Version: 2.1.2.9000
Version: 2.2.0
License: GPL (>= 2.0)
Title: Extension to 'ggplot2'
Type: Package
Expand Down Expand Up @@ -43,7 +43,8 @@ Imports:
RColorBrewer,
rlang,
scales (>= 1.1.0),
utils
utils,
magrittr
Suggests:
broom (>= 0.7.0),
broom.helpers (>= 1.3.0),
Expand Down
2 changes: 1 addition & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ export(wrapp)
import(RColorBrewer)
import(ggplot2)
import(utils)
importFrom(dplyr,"%>%")
importFrom(dplyr,all_of)
importFrom(dplyr,group_by)
importFrom(dplyr,rename)
Expand Down Expand Up @@ -166,6 +165,7 @@ importFrom(grid,upViewport)
importFrom(grid,viewport)
importFrom(gtable,gtable_filter)
importFrom(lifecycle,deprecate_soft)
importFrom(magrittr,"%>%")
importFrom(plyr,ddply)
importFrom(plyr,summarize)
importFrom(rlang,"%||%")
Expand Down
6 changes: 3 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# GGally (development version)
# GGally 2.2.0

### Bug fixes

* removed dependency on reshape2 (#475)
* Removed dependency on reshape2 (#475)
* Reverse ordering of y-axis in `ggally_count()` (#420)
* Facets ordering in `ggcoef_compare()` (#426)
* Fix in `ggcoef_compare()` when using tidy selectors for
Expand All @@ -12,7 +12,7 @@
* New default tidier for `ggcoef_model()`, now using
`broom.helpers::tidy_with_broom_or_parameters()` (#432)
* Re-export methods from and redirect vignettes to the `{ggstats}` package (#452, #457)
* Replaced ..scaled.. with after_stat(scaled) in ggscatmat (#467)
* Replaced `..scaled..` with `after_stat(scaled)` in ggscatmat (#467)


# GGally 2.1.2
Expand Down
12 changes: 0 additions & 12 deletions R/GGally-package.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,3 @@ NULL
# \lifecycle{deprecated}
# \lifecycle{defunct}
# \lifecycle{archived}

#' Pipe operator
#'
#' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details.
#'
#' @name %>%
#' @rdname pipe
#' @keywords internal
#' @export
#' @importFrom dplyr %>%
#' @usage lhs \%>\% rhs
NULL
2 changes: 1 addition & 1 deletion R/ggcoef.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#' @param exclude_intercept should the intercept be excluded from the plot?
#' @param vline print a vertical line?
#' @param vline_intercept \code{xintercept} for the vertical line.
#' \code{"auto"} for \code{x = 0} (or \code{x = 1} if {exponentiate} is \code{TRUE})
#' \code{"auto"} for \code{x = 0} (or \code{x = 1} if \code{exponentiate} is \code{TRUE})
#' @param vline_color color of the vertical line
#' @param vline_linetype line type of the vertical line
#' @param vline_size size of the vertical line
Expand Down
2 changes: 1 addition & 1 deletion R/ggnostic.R
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ ggally_nostic_sigma <- function(
#' A function to display [stats::cooks.distance()].
#'
#' @details
#' A line is added at F_{p, n - p}(0.5) to display the general cutoff point for Cook's Distance.
#' A line is added at \eqn{F_{p,n-p}(0.5)}{F[p,n-p](0.5)} to display the general cutoff point for Cook's Distance.
#'
#' Reference: Michael H. Kutner, Christopher J. Nachtsheim, John Neter, and William Li. Applied linear statistical models. The McGraw-Hill / Irwin series operations and decision sciences. McGraw-Hill Irwin, 2005, p. 403
#'
Expand Down
12 changes: 7 additions & 5 deletions R/ggparcoord.R
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if (getRversion() >= "2.15.1") {
#'
#' \code{scale} is a character string that denotes how to scale the variables
#' in the parallel coordinate plot. Options:
#' \itemize{
#' \describe{
#' \item{\code{std}}{: univariately, subtract mean and divide by standard deviation}
#' \item{\code{robust}}{: univariately, subtract median and divide by median absolute deviation}
#' \item{\code{uniminmax}}{: univariately, scale so the minimum of the variable is zero, and the maximum is one}
Expand All @@ -24,7 +24,7 @@ if (getRversion() >= "2.15.1") {
#'
#' \code{missing} is a character string that denotes how to handle missing
#' missing values. Options:
#' \itemize{
#' \describe{
#' \item{\code{exclude}}{: remove all cases with missing values}
#' \item{\code{mean}}{: set missing values to the mean of the variable}
#' \item{\code{median}}{: set missing values to the median of the variable}
Expand All @@ -34,7 +34,7 @@ if (getRversion() >= "2.15.1") {
#'
#' \code{order} is either a vector of indices or a character string that denotes how to
#' order the axes (variables) of the parallel coordinate plot. Options:
#' \itemize{
#' \describe{
#' \item{\code{(default)}}{: order by the vector denoted by \code{columns}}
#' \item{\code{(given vector)}}{: order by the vector specified}
#' \item{\code{anyClass}}{: order variables by their separation between any one class and
Expand Down Expand Up @@ -452,12 +452,14 @@ ggparcoord <- function(
# mappingNames <- names(mapping)
# }
# data.m <- melt(data, id.vars = meltIDVars, measure.vars = columns)
data.m <- pivot_longer(
# Return a data.frame for freqparcoord::freqparcoord.
# The method uses vector recycling, which is not allowed in a tibble
data.m <- as.data.frame(pivot_longer(
data,
cols = all_of(columns),
names_to = "variable",
values_to = "value"
)
))

### Ordering ###
if (length(order) > 1 && is.numeric(order)) {
Expand Down
14 changes: 14 additions & 0 deletions R/utils-pipe.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#' Pipe operator
#'
#' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details.
#'
#' @name %>%
#' @rdname pipe
#' @keywords internal
#' @export
#' @importFrom magrittr %>%
#' @usage lhs \%>\% rhs
#' @param lhs A value or the magrittr placeholder.
#' @param rhs A function call using the magrittr semantics.
#' @return The result of calling `rhs(lhs)`.
NULL
75 changes: 48 additions & 27 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,56 +1,77 @@

## Comments
#### 2021-06-20
#### 2023-11-22

I have fixed the failing tests due to an update in `network` package. `GGally` now requires the latest version of the `network` package and should pass the tests.
Thank you for being patient with me on my submission.

Thank you,
I have fixed the packageVersion issue by removing the unecessary code: https://github.com/ggobi/ggally/commit/9e7228c6d4219c515857426a982d1a5c1ff0cd13

The update also contains bug fixes and new datasets.

Please let me know if there is anything else I can do to help. Thank you again for your patience!!

Best,
Barret

#### 2021-06-08

Dear maintainer,
#### 2023-11-07

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_GGally.html>.
Can you please change to "3.3"?

Please correct before 2021-06-22 to safely retain your package on CRAN.
Please fix before 2023-11-21 to safely retain your package on CRAN.

Best,
Best
-k


#### 2023-07-18

[packageVersion() should only compare against strings.]

....

Please correct before 2023-08-16 to safely retain your package on CRAN.

....

Best
-k

**********************************

$GGally
$GGally$`GGally/R/gg-plots.R`
$GGally$`GGally/R/gg-plots.R`[[1]]
packageVersion("ggplot2") >= 3.3



## Test environments and R CMD check results
## R CMD check results

* local macOS install 11.3.1
* R 4.0
* GitHub Actions - https://github.com/ggobi/ggally/pull/419/checks
* macOS, windows, ubuntu {16,20} - R release
* macOS, windows, ubuntu {16,20} - R oldrelease
* 0 errors | 0 warnings | 1 note

* win-builder
* devel
* release
* oldrelease
Maintainer: ‘Barret Schloerke <[email protected]>

#### R CMD check results
Found the following (possibly) invalid URLs:
URL: https://www.oecd.org/pisa/pisaproducts/database-cbapisa2012.htm
From: man/australia_PISA2012.Rd
Status: 403
Message: Forbidden

* 0 errors | 0 warnings | 0 notes
When visiting the link manually, the link works as expected. I believe they have a bot blocker that is causing this error.


## revdepcheck results

We checked 125 reverse dependencies (100 from CRAN + 25 from BioConductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 158 reverse dependencies (128 from CRAN + 30 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 2 packages
* We failed to check 3 packages

Issues with CRAN packages are summarised below.

### Failed to check

* egoTERGM (NA)
* Package is archived. I believe this is a false positive
* loon.ggplot (NA)
* Could not install `loon`. The changes made for this release should have a negative effect on their code.
* fingerPro (NA) - depends on rjags; Could not install rjags
* loon.ggplot (NA) - Trying to attached to a null device
* simmr (NA) - depends on rjags; Could not install rjags
1 change: 1 addition & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -175,3 +175,4 @@ Homewood
ibb
rbi
sb
magrittr
2 changes: 1 addition & 1 deletion man/ggally_nostic_cooksd.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/ggcoef.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions man/ggparcoord.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion man/pipe.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f6cd613

Please sign in to comment.