Don't rotate the player assigned to the role 'random' when generating… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple matches The current code rotates all players when generating multiple matches for the same game. This change leaves the player associated with the 'random' role at the same index in the player list and rotates all the other players. If there is no player associated with the 'random' role, the code works as before.
|
Sorry for the slow response here. Was travelling; now catching up on everything I missed. This is on my radar. |
|
Some initial thoughts:
|
|
Sam, I agree with you on both points. I will spend some time on these and send along my proposed solutions. Do you plan on checking this in in the current state? It might take me a week or two to get back to this. |
|
Sam, not a problem on the delay. I figured you might be on vacation or travelling. |
| @@ -244,10 +244,38 @@ public void actionPerformed(ActionEvent evt) { | |||
| thePlayers.add(playerSelector.getPlayerPresence(name)); | |||
| } | |||
|
|
|||
| StateMachine stateMachine = new ProverStateMachine(); | |||
| stateMachine.initialize(theGame.getRules()); | |||
| List<Role> roles = stateMachine.getRoles(); | |||
There was a problem hiding this comment.
You can use Role#computeRoles for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… multiple matches
The current code rotates all players when generating multiple matches
for the same game. This change leaves the player associated with the
'random' role at the same index in the player list and rotates all the
other players. If there is no player associated with the 'random' role,
the code works as before.