Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of two PRs being made to overcome emulation issues running ELKS on MartyPC. Discussed in detail in #2678.
This PR works around new information that the VERSION command is in fact not implemented in uDP765 FDC chips. While real hardware returns an invalid command code of 0x80 which is handled by the ELKS DF driver, MartyPC does not (yet) do so. This workaround now reports "8272A assumed" and allows continuation of the boot, rather than disallowing further DF driver use as was done previously.
During testing it was found that when a 2.88M floppy image is booted using the DF driver, an incorrect and unnecessary message "df: need 82077 FDC for disc" was displayed and the driver possibly not initialized correctly. This is also fixed in this PR.