Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow recursive schemas #104

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

simon-schoonjans
Copy link
Contributor

support JSON schemas that recursively reference themselves

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (46684c6) to head (de67486).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   99.22%   99.34%   +0.12%     
==========================================
  Files          31       31              
  Lines        1158     1230      +72     
==========================================
+ Hits         1149     1222      +73     
+ Misses          9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon-schoonjans
Copy link
Contributor Author

simon-schoonjans commented Mar 6, 2024

I will add an additional test to imrpove coverage

@simon-schoonjans simon-schoonjans force-pushed the fix/recursive_schema branch 2 times, most recently from 021b739 to 6c36a65 Compare March 6, 2024 16:33
Copy link
Owner

@ghandic ghandic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghandic ghandic merged commit 4d8a20e into ghandic:main Mar 10, 2024
6 checks passed
@ghandic
Copy link
Owner

ghandic commented Mar 10, 2024

Thanks for the contributions! These are now released as part of jsf==0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants