-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document all of the geometries #188
Merged
ghettovoice
merged 4 commits into
ghettovoice:master
from
categulario:categulario/docs-all-geoms
Jul 2, 2019
Merged
Document all of the geometries #188
ghettovoice
merged 4 commits into
ghettovoice:master
from
categulario:categulario/docs-all-geoms
Jul 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghettovoice
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thanks!
Published. Look very nice 👍 |
ghettovoice
added a commit
that referenced
this pull request
Oct 3, 2019
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230 - merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208, #212, #213, #215, #221, #227, #231 Thanks to @baspeeters, @sjmallon, @janlazo, @categulario, @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange - improved property watchers - optional debug messages - fixed broken UMD version - simplified initial interaction/controls setup #95 - added `id` property for all ol components for easy identification - mixins, ol-ext and rx-ext now are build to single file package, imports from those packages are not changed - UMD version (dev/demo version) now includes all used stuff from `ol` package - updated documentation and README
ghettovoice
added a commit
that referenced
this pull request
Oct 3, 2019
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230 - merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208, #212, #213, #215, #221, #227, #231 Thanks to @baspeeters, @sjmallon, @janlazo, @categulario, @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange - improved property watchers - optional debug messages - fixed broken UMD version - simplified initial interaction/controls setup #95 - added `id` property for all ol components for easy identification - mixins, ol-ext and rx-ext now are build to single file package, imports from those packages are not changed - UMD version (dev/demo version) now includes all used stuff from `ol` package - updated documentation and README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step towards completion of #34. This time all of the geometries are documented except for the circle because that one comes in #185.