feat!: drop standalone legacy browser <script> & window object usage#164
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 25 25
Lines 1803 1803
Branches 349 349
=====================================
Hits 1801 1801
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This pull request is included in version 5.0.0 📦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<script>(previously available indist/browserand via CDN)<script type="module">import { createWorkbook, downloadExcelFile } from 'excel-builder-vanilla'; // ... </script>or load from CDNwindowobject to store thingsFor a more modern approach, we should stop using the
windowobject as a local variable to store the ExcelBuilder instance itself. That was the legacy approach of JavaScript libraries and we should go away from that approach. This should bring positive changes to the end user, less memory usage (because we no longer override thewindowobject) and a more modern approach