Skip to content

feat!: drop standalone legacy browser <script> & window object usage#164

Merged
ghiscoding merged 1 commit into
mainfrom
feat/drop-legacy-script
Feb 4, 2026
Merged

feat!: drop standalone legacy browser <script> & window object usage#164
ghiscoding merged 1 commit into
mainfrom
feat/drop-legacy-script

Conversation

@ghiscoding
Copy link
Copy Markdown
Owner

@ghiscoding ghiscoding commented Feb 3, 2026

⚠️ Breaking Change

  • drop legacy browser <script> (previously available in dist/browser and via CDN)
    • the end user will now have to use modern approach like <script type="module">import { createWorkbook, downloadExcelFile } from 'excel-builder-vanilla'; // ... </script> or load from CDN
  • stop using the window object to store things

For a more modern approach, we should stop using the window object as a local variable to store the ExcelBuilder instance itself. That was the legacy approach of JavaScript libraries and we should go away from that approach. This should bring positive changes to the end user, less memory usage (because we no longer override the window object) and a more modern approach

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.9%. Comparing base (addbca1) to head (8658f49).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #164   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files         25      25           
  Lines       1803    1803           
  Branches     349     349           
=====================================
  Hits        1801    1801           
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding ghiscoding merged commit 0575191 into main Feb 4, 2026
6 of 8 checks passed
@ghiscoding ghiscoding deleted the feat/drop-legacy-script branch February 4, 2026 04:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🎉 This pull request is included in version 5.0.0 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant