Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 20.04 #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amateo
Copy link

@amateo amateo commented Jun 24, 2020

Since Ubuntu 16.04 the plugins package is monitoring-plugins-basic but
a metapackage named nagios-plugins-basic (which install the former) is
maintained. In Ubuntu 20.04 this metapackage does not exist.

@amateo
Copy link
Author

amateo commented Jun 24, 2020

I don't know why travis is failing in all tests with errors which are not related with any change I have made.

Do you have any idea?

@ghoneycutt
Copy link
Owner

Thanks for the contribution! We need an update the ubuntu portion of the spec test that shows that the new package name is used on Ubuntu 20.04. See https://github.com/ghoneycutt/puppet-module-nrpe/blob/master/spec/classes/init_spec.rb

There should also be an update to the README.md (https://github.com/ghoneycutt/puppet-module-nrpe#compatibility) and to the metadata.json

@amateo amateo force-pushed the ubuntu-20.04 branch 2 times, most recently from b6bbdbb to 0b64517 Compare June 25, 2020 06:46
@amateo
Copy link
Author

amateo commented Jun 25, 2020

I have patched the files you asked for.

But there are still problems with integration tests. I have no idea, because all tests are failling and reported problems have no relation with my changes.

Since Ubuntu 16.04 the plugins package is `monitoring-plugins-basic` but
a metapackage named `nagios-plugins-basic` (which install the former) is
maintained. In Ubuntu 20.04 this metapackage does not exist, so it
is appropriately updated.
@amateo
Copy link
Author

amateo commented Jun 30, 2020

@ghoneycutt, any idea for the travis errors?

They are errors like:

ERROR:  Error installing rubygems-update:

	There are no versions of rubygems-update (= 3.1.4) compatible with your Ruby & RubyGems

	rubygems-update requires Ruby version >= 2.3.0. The current ruby version is 1.9.1.

ERROR:  While executing gem ... (Errno::ENOENT)

    No such file or directory - /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/rubygems-update-2.7.8

The command "gem update --system" failed and exited with 1 during .

that are not (apparently) related with my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants