Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing vim-tiny from default installation #193

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jun 22, 2024

No description provided.

@ericbsd ericbsd requested a review from a team as a code owner June 22, 2024 00:07
@ericbsd ericbsd linked an issue Jun 22, 2024 that may be closed by this pull request
Copy link
Contributor

sourcery-ai bot commented Jun 22, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit c911fda into master Jun 22, 2024
2 checks passed
@ericbsd ericbsd deleted the 147-remove-vim-we-have-vi-by-default branch June 22, 2024 00:08
@ericbsd ericbsd self-assigned this Aug 5, 2024
@ericbsd ericbsd added the task label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove vim we have vi by default
1 participant