Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ghostbsd-build to install the OS from PKGBASE #194

Merged

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jun 29, 2024

Summary by Sourcery

This pull request updates the GhostBSD build script to install the operating system from PKGBASE. It includes changes to filter base packages, dynamically read the base package list, and use pkg-static for package installation.

  • Enhancements:
    • Modified the build script to install the OS from PKGBASE by filtering packages with 'base' in their name.
    • Updated the base function to dynamically read the base package list from a file and install it using pkg-static.
    • Adjusted the packages_software function to use pkg-static for installing software packages and added a step to create necessary directories.

@ericbsd ericbsd self-assigned this Jun 29, 2024
@ericbsd ericbsd linked an issue Jun 29, 2024 that may be closed by this pull request
Copy link
Contributor

sourcery-ai bot commented Jun 29, 2024

Reviewer's Guide by Sourcery

This pull request refactors the 'build.sh' script to install the OS from PKGBASE. The changes include filtering the 'desktop_list' to include only base packages, reordering 'umount' commands, reading base packages from a file, and updating 'pkg-static' commands to use these lists. Additionally, a new directory creation command was added in the 'packages_software' function.

File-Level Changes

Files Changes
build.sh Refactored package installation logic to use lists from files and reordered some commands for better organization.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

build.sh Show resolved Hide resolved
build.sh Show resolved Hide resolved
build.sh Show resolved Hide resolved
build.sh Show resolved Hide resolved
@ericbsd ericbsd requested review from a team June 29, 2024 21:27
@ericbsd ericbsd merged commit 6339768 into master Jun 29, 2024
1 check passed
@ericbsd ericbsd deleted the 156-change-ghostbsd-build-to-build-the-iso-with-pkgbase branch June 29, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change ghostbsd-build to build the ISO with pkgbase.
1 participant