Add hgame to kld_list #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hgame driver "provides support for generic game controllers" which is extremely helpful for a desktop implementation of an operating system since most people like games. Some games throw fatal errors if it is not loaded even if a gamepad is not intended to be connected.
Reviewer's Guide by SourceryThis pull request adds the 'hgame' driver to the kld_list in the build.sh file. The change is intended to provide support for generic game controllers in the desktop implementation of the operating system. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @adrylain - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hgame driver "provides support for generic game controllers" which is extremely helpful for a desktop implementation of an operating system since most people like games. Some games throw fatal errors if it is not loaded even if a gamepad is not intended to be connected.
I see this as a fairly harmless quality of life / convenience change.
Summary by Sourcery
Add 'hgame' to the kld_list in the build script to enable support for generic game controllers, enhancing the user experience by preventing fatal errors in some games.
Build: