Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

custom CSS styles for links and blocks #5

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

qyloxe
Copy link

@qyloxe qyloxe commented Apr 22, 2020

Hello, this project looks very promising. Your code is beautiful and clean. I'd like to try to use vue-blocks in my side Quasar project and hope, that those (and more in future) changes will somehow be up to your high quality of code. Cheers!

@ghostiam
Copy link
Owner

Hello. Thank you for the PR and compliments.
I will accept your PR, but could you make some changes.

  • Remove empty blocks from css (you marked them as "empty ruleset") to make the code cleaner.
  • Correct the "delete" button in height, now it is stuck to the top edge.
  • In "deleteMark" need to enable html tags, for example, to use font awesome.

Thank you.

2020-04-22 в 12 40 23

@qyloxe
Copy link
Author

qyloxe commented Apr 22, 2020

hmm, I'm not sure if this is correct way to push today commits to your great repository... Little confused haha
Anyway, the changes has been made and there are some new additions. In the spirit of styling there is an option for default styles for the blocks.

BEWARE: there are intentionally ugly colors in current App.vue demonstration! We should check if this is in spirit with your code. I'm not entirely convinced, that the new names for variables etc. are ideally matching your style.

Food for thought:

  • wonder if blocks should have default styles, too?

  • the z-index of links is not compatible with blocks - the links are behind the panel and blocks are above:
    image

  • wonder if global defaults should be also exported and imported

  • have some problems with javascript import of this package, maybe it is something with package.json and module params in it?

  • I wonder if updating the scene should be guarded by debouncer? Of if this should be an option?

I plan to check this awesome vue-blocks in Quasar framework, for example, there is a debouncer out of the box:
https://quasar.dev/quasar-utils/other-utils#Debounce-Function

@ghostiam
Copy link
Owner

ghostiam commented Apr 23, 2020

wonder if blocks should have default styles, too?

I think yes.

the z-index of links is not compatible with blocks - the links are behind the panel and blocks are above:

A panel is not part of the project, it is just an example of how to use custom variables in blocks.

wonder if global defaults should be also exported and imported

if you are talking about the state of blocks and scenes, then I think it should be empty.

have some problems with javascript import of this package, maybe it is something with package.json and module params in it?

Oh, yes, I think you're right, I did not know about this setting, check to see if it was fixed. 87fbb4d

I wonder if updating the scene should be guarded by debouncer? Of if this should be an option?

That's a good question. I had no problems with it, but most likely, the problem may be.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants