Move Nitro emojis #157
Closed
Move Nitro emojis #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00-kat
commented
Feb 17, 2025
app/utils/webhooks.py
Outdated
| _EMOJI_REGEX = re.compile(r"<(a?):(\w+):(\d+)>", re.ASCII) | ||
|
|
||
|
|
||
| def _convert_nitro_emojis(s: str) -> str: |
There was a problem hiding this comment.
Not sure where to put it. It's unlikely to be used outside of the move_message_via_webhook() function, but it also doesn't feel right leaving it in webhook.py. I can't put it in __init__.py as that would cause a circular dependency.
00-kat
commented
Feb 17, 2025
00-kat
force-pushed
the
move-nitro-emojis
branch
from
dda043f to
4e9f037
Compare
Closed
trag1c
force-pushed
the
another-cleanup
branch
2 times, most recently
from
eb4ddfd to
fc56c5b
Compare
This is similar to the “fake-nitro” extension in some things-that-shall-not-be-named.
00-kat
force-pushed
the
move-nitro-emojis
branch
from
4e9f037 to
3f3aed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the first part of #155.