-
Notifications
You must be signed in to change notification settings - Fork 12
feat: auto cleanup webhooks #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CoderJoshDK
wants to merge
3
commits into
ghostty-org:main
Choose a base branch
from
CoderJoshDK:issue_cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+51
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ae5aad
to
154bec6
Compare
00-kat
reviewed
Sep 30, 2025
00-kat
reviewed
Sep 30, 2025
b5759fb
to
8489cf8
Compare
8489cf8
to
f24c3de
Compare
trag1c
reviewed
Oct 4, 2025
trag1c
requested changes
Oct 4, 2025
Co-authored-by: trag1c <[email protected]>
cf7cb27
to
495727a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387
This PR cleans up embeds sent from webhook logic. This handles the
<sup>
and<sub>
tags and shortens long GH links into hyperlinks, when possible and logical. This does not convert things like#123
into a hyperlink.Created issues might also have
div
tags that should be removed. A tag that comes from converting a discussion into an issue. It just takes up space that we can ignore on creation.