macos: move ownership of fullscreenNotification observers to Terminal…

…Controller

When processing toggle_fullscreen actions, multiple FullscreenStyle
derived objects would register observers on the same window and
subsequently remove them when the old style was deinited.

This change passes ownership of the fullscreenNotification observers to
TerminalController while still allowing FullscreenStyles access to the
window for style specific actions.

macos/Sources/Features/Terminal/TerminalController.swift

@@ -71,6 +71,17 @@ class TerminalController: BaseTerminalController {
             selector: #selector(onFrameDidChange),
             name: NSView.frameDidChangeNotification,
             object: nil)
+
+        center.addObserver(
+            self,
+            selector: #selector(didEnterFullScreenNotification),
+            name: NSWindow.didEnterFullScreenNotification,
+            object: window)
+        center.addObserver(
+            self,
+            selector: #selector(didExitFullScreenNotification),
+            name: NSWindow.didExitFullScreenNotification,
+            object: window)
     }
 
     required init?(coder: NSCoder) {
@@ -686,6 +697,14 @@ class TerminalController: BaseTerminalController {
         targetWindow.makeKeyAndOrderFront(nil)
     }
 
+    @objc private func didEnterFullScreenNotification(_ notification: Notification) {
+        fullscreenDidChange()
+    }
+
+    @objc private func didExitFullScreenNotification(_ notification: Notification) {
+        fullscreenDidChange()
+    }
+
     @objc private func onToggleFullscreen(notification: SwiftUI.Notification) {
         guard let target = notification.object as? Ghostty.SurfaceView else { return }
         guard target == self.focusedSurface else { return }

macos/Sources/Helpers/Fullscreen.swift

@@ -52,33 +52,6 @@ class FullscreenBase {
 
     required init?(_ window: NSWindow) {
         self.window = window
-
-        // We want to trigger delegate methods on window native fullscreen
-        // changes (didEnterFullScreenNotification, etc.) no matter what our
-        // fullscreen style is.
-        let center = NotificationCenter.default
-        center.addObserver(
-            self,
-            selector: #selector(didEnterFullScreenNotification),
-            name: NSWindow.didEnterFullScreenNotification,
-            object: window)
-        center.addObserver(
-            self,
-            selector: #selector(didExitFullScreenNotification),
-            name: NSWindow.didExitFullScreenNotification,
-            object: window)
-    }
-
-    deinit {
-        NotificationCenter.default.removeObserver(self)
-    }
-
-    @objc private func didEnterFullScreenNotification(_ notification: Notification) {
-        delegate?.fullscreenDidChange()
-    }
-
-    @objc private func didExitFullScreenNotification(_ notification: Notification) {
-        delegate?.fullscreenDidChange()
     }
 }