Skip to content

Conversation

@MithicSpirit
Copy link
Contributor

@MithicSpirit MithicSpirit commented Jan 11, 2026

As of NixOS/nixpkgs#473413, zig.hook no longer supports zig_default_flags, and now they can and must be provided in zigBuildFlags instead.

Updating also requires removing gnome-xorg since it has been removed from nixpkgs.

nix flake check succeeds on my system (x86_64-linux), with a couple deprecation warnings that I believe aren't important.

@MithicSpirit MithicSpirit changed the title nix: update unstable and remove zig.hook nix: update unstable, remove zig.hook, and remove x11-gnome Jan 11, 2026
@MithicSpirit MithicSpirit marked this pull request as ready for review January 11, 2026 23:54
@MithicSpirit MithicSpirit changed the title nix: update unstable, remove zig.hook, and remove x11-gnome nix: update nixpkgs, remove zig.hook, and remove x11-gnome Jan 12, 2026
As of NixOS/nixpkgs#473413[1], `zig.hook` no longer supports
`zig_default_flags`, and now they can and must be provided in
`zigBuildFlags` instead.

Updating also requires removing gnome-xorg since it has been removed
from nixpkgs.

[1] NixOS/nixpkgs#473413
@MithicSpirit
Copy link
Contributor Author

I think the failures are an OOM error or something like that because it's having to recompile zig, which seems to be pulled in by zon2nix, since it still uses zig_default_flags. I'll try changing it to not need that.

Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this as a temporary fix, pending CI. Later please follow through with this and make a PR on the zon2nix repo, and then remove the overridden zon2nix here :)

@jcollie
Copy link
Member

jcollie commented Jan 12, 2026

I've updated zon2nix to be compatible with the Zig hook changes in nixpkgs.

@MithicSpirit
Copy link
Contributor Author

I've updated zon2nix to be compatible with the Zig hook changes in nixpkgs.

@jcollie really? The latest commit on jcollie/zon2nix is still using zig_default_flags. Maybe you forgot to push?

@jcollie
Copy link
Member

jcollie commented Jan 12, 2026

Whoops, yeah forgot to push.

After the last commit, zon2nix required recompiling zig, which caused
slow build times and CI failures.
@MithicSpirit
Copy link
Contributor Author

I don't think the CI failures are my fault? I guess maybe updating nixpkgs updated dependencies like the spellchecker, which could be causing the failures. Regardless, I can try to fix them if desired. The action pins and typos seem pretty straightforward, but I'm not sure what should be done about the HttpConnectionClosing in test.

@jcollie
Copy link
Member

jcollie commented Jan 12, 2026

The HttpConnectionClosing is typically a transient networking error that can be "fixed" by retrying. The typos failure is probably caused by a newer version of typos being pickier. The GH actions pins may be a similar issue. Both of those should get fixed in this PR.

Detected by CI (typos) after nixpkgs update.
Does not entail any actual changes in the version, merely in the comment
indicating the used version.

Detected by CI (GitHub Action Pins) after nixpkgs update.
@MithicSpirit MithicSpirit requested a review from a team as a code owner January 12, 2026 18:17
@mitchellh mitchellh merged commit 136df4a into ghostty-org:main Jan 12, 2026
10 checks passed
@mitchellh mitchellh added this to the 1.3.0 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants