-
Notifications
You must be signed in to change notification settings - Fork 1.4k
nix: update nixpkgs, remove zig.hook, and remove x11-gnome #10286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d4653df to
4be241e
Compare
4be241e to
6c98014
Compare
As of NixOS/nixpkgs#473413[1], `zig.hook` no longer supports `zig_default_flags`, and now they can and must be provided in `zigBuildFlags` instead. Updating also requires removing gnome-xorg since it has been removed from nixpkgs. [1] NixOS/nixpkgs#473413
6c98014 to
5c8c7c6
Compare
|
I think the failures are an OOM error or something like that because it's having to recompile zig, which seems to be pulled in by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this as a temporary fix, pending CI. Later please follow through with this and make a PR on the zon2nix repo, and then remove the overridden zon2nix here :)
|
I've updated |
@jcollie really? The latest commit on jcollie/zon2nix is still using |
|
Whoops, yeah forgot to push. |
After the last commit, zon2nix required recompiling zig, which caused slow build times and CI failures.
ca4ba01 to
d512de7
Compare
|
I don't think the CI failures are my fault? I guess maybe updating nixpkgs updated dependencies like the spellchecker, which could be causing the failures. Regardless, I can try to fix them if desired. The action pins and typos seem pretty straightforward, but I'm not sure what should be done about the |
|
The |
Detected by CI (typos) after nixpkgs update.
Does not entail any actual changes in the version, merely in the comment indicating the used version. Detected by CI (GitHub Action Pins) after nixpkgs update.
As of NixOS/nixpkgs#473413,
zig.hookno longer supportszig_default_flags, and now they can and must be provided inzigBuildFlagsinstead.Updating also requires removing gnome-xorg since it has been removed from nixpkgs.
nix flake checksucceeds on my system (x86_64-linux), with a couple deprecation warnings that I believe aren't important.