Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: implement splitting leftwards and upwards #2255

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented Sep 17, 2024

Fixes #2227

Unresolved problems:

  • Currently unimplemented on macOS :(
  • What should be the default keybinds? The default keybinds for the existing two directions already make little sense as they are...

@mitchellh mitchellh force-pushed the feat/situs-inversus branch from 07a6c85 to 712d2f4 Compare October 8, 2024 01:15
@mitchellh mitchellh force-pushed the feat/situs-inversus branch from 712d2f4 to fbc621a Compare October 8, 2024 01:19
@mitchellh mitchellh changed the title [DRAFT] gtk: implement splitting leftwards and upwards DRAFT: implement splitting leftwards and upwards Oct 8, 2024
@mitchellh
Copy link
Contributor

Rebased and touched up some of the logic for opinions. I also started working on the macOS side. I don't think these should be bound by default. Just having them available as options is good enough. I want to finish the macOS logic before merge, it isn't complicated.

@mitchellh mitchellh force-pushed the feat/situs-inversus branch from 556dcd9 to 973c427 Compare October 8, 2024 01:33
@mitchellh mitchellh force-pushed the feat/situs-inversus branch from 973c427 to 3928753 Compare October 8, 2024 01:34
@mitchellh
Copy link
Contributor

macOS works. I want to do some additional testing.

@mitchellh mitchellh merged commit 78d6cfb into ghostty-org:main Oct 8, 2024
16 of 17 checks passed
@mitchellh mitchellh deleted the feat/situs-inversus branch October 8, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action to create left split with custom size
2 participants