Use foreground color in macOS tab titles #3843
Open
+91
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently tab titles will use the default macOS tab foreground color, but the color schemes background color. This can result in tabs with unreadable text. This change updates the macOS UI tabs to use the foreground color defined in the config, or the overridden value when set dynamically. This change: - Tracks `foregroundColor` in the SurfaceView which is pre-populated with the config foreground color along with support for color change update events. - Adds a new `titleForegroundColor` property to use in `TerminalWindow` titles. - Updates each tab window foreground color when `syncAppearance` is called. - Calls `syncAppearance` when a window becomes the key window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a Zig or a Swift/macOS developer but I've been really liking GhostTTY and wanted to open this PR to either contribute back, or at least share the progress/learnings when tackling #2764 (which I think this should close, if this is a valid approach). I have a vimscript that syncs the terminal colors with my vim theme, so I was pretty motivated to implement this feature.
This change was relatively straightforward (but required a lot of learning). In general it:
foregroundColorin the SurfaceView. It's pre-populated with the config defined foreground color. It is also updated via the color change events (which I added foreground support to)titleForegroundColorproperty to use inTerminalWindowtitles so the colors can be updated dynamically.syncAppearanceis called. (I'm honestly not sure if this is the best approach, but it's the solution I found. happy to update if there's a better approach)syncAppearancewhen a window becomes the key window to sync the colors across each tab.systemFontSizeto match the existing behavior/size of tabs (happy to provide screenshots to elaborate)Here's a quick screencap of the new behavior:
Kapture.2024-12-28.at.21.49.46.mp4
I also quickly validated that this works with `macos-titlebar-style=transparent` in addition to `tabs`
and just for completions sake, bg transparency: