Clarify CLI vs. Keybind Actions documentation #4116
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisher
force-pushed
the
clarify-cli-vs-keybind-actions-documentation
branch
from
35a1feb to
57ace2d
Compare
mitchellh
added a commit
that referenced
this pull request
Jan 2, 2025
#4107 (comment) I was confused about not being able to run `ghostty +new_window` since I hadn't read the docs closely enough to understand the distinction between Keybind Actions and CLI Actions. I think if the error messages I've modified here would have read this way to begin with I would've had a better chance of discovering this distinction on my own. I did read the Contributing guidelines but I avoided opening an Issue since the changes here are minimal enough that I felt it would just add noise. If that's a mistake then I'm happy to close this out and return to the original discussion and/or create a new Issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4107 (comment)
I was confused about not being able to run
ghostty +new_windowsince I hadn't read the docs closely enough to understand the distinction between Keybind Actions and CLI Actions.I think if the error messages I've modified here would have read this way to begin with I would've had a better chance of discovering this distinction on my own.
I did read the Contributing guidelines but I avoided opening an Issue since the changes here are minimal enough that I felt it would just add noise. If that's a mistake then I'm happy to close this out and return to the original discussion and/or create a new Issue.