macos: when toggling visibility, hide individual windows not app #8636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ghostty-org#8414 Previously, toggling visibility on Mac was implemented via NSApp.hide(). This caused a bug where bringing up the quick terminal would unintentionally restore hidden windows. It appears making any window key and front will first unhide the app. This diff fixes the issue by first manually removing the visible windows from the window list. Windows that are ordered out aren't restored automatically when a different window (the quick terminal) is made key and front. Disclosure: I consulted GPT-5 Thinking on the trade offs between hiding the app, ordering out windows, and minaturizing windows.
mitchellh
requested changes
Sep 15, 2025
| windowStash.hideAll() | ||
|
|
||
| // Deactivate the app, as we no longer have any visible windows | ||
| NSApp.hide(nil) |
There was a problem hiding this comment.
This still seems to use NSApp.hide?
There was a problem hiding this comment.
I can see how that's confusing. Windows are hidden with window.orderOut() in hideAll(), but we still need NSApp.hide(nil) to deactivate the app and bring whatever app was running behind Ghostty in the stack to the foreground.
| // We need to know the key window so that we can bring focus back to the | ||
| // right window if it was hidden. | ||
| self.keyWindow = if let keyWindow = NSApp.keyWindow { | ||
| self.keyWindow = if let keyWindow = NSApp.keyWindow, !keyWindow.styleMask.contains(.nonactivatingPanel) { |
There was a problem hiding this comment.
What's the reasoning behind ignoring nonactivatingPanel. What does Ghostty have that triggers this?
There was a problem hiding this comment.
The quick terminal is a non-activating panel.
00-kat
added
os/macos
gui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8414
Previously, toggling visibility on Mac was implemented via NSApp.hide(). This caused a bug where bringing up the quick terminal would unintentionally restore hidden windows. It appears making any window key and front will first unhide the app.
This diff fixes the issue by first manually removing the visible windows from the window list. Windows that are ordered out aren't restored automatically when a different window (the quick terminal) is made key and front.
Disclosure: I consulted GPT-5 Thinking on the trade offs between hiding the app, ordering out windows, and minaturizing windows.