Decouple balanced top and left window paddings to avoid diagonal resize jitter #9518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwe
force-pushed
the
vertical_balance
branch
from
8379831 to
9339ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bit of the same annoyance as #9064. I agree that with balanced padding, you should expect horizontal jitter when resizing horizontally, and vertical jitter when resizing vertically. Diagonal jitter, however, happened because the top padding was upper bounded by the left padding, coupling the vertical and horizontal wobbling. This looks kind of janky, and it's surprising that the balance between top and bottom padding changes as you vary only the width of the window.
With this PR, the upper bound is instead equal to the maximum left padding. Since this only depends on the config, not the current window width, the diagonal wobbling is avoided. Both the top and left padding still have the same range of motion as before.
An alternative could be to bound by the minimum or median left padding instead. Open to suggestions.
Before
Screen.Recording.2025-11-08.at.12.11.54.mov
After
Screen.Recording.2025-11-08.at.12.11.17.mov