Skip to content

fix: skip SSH agent when no keys loaded to prevent auth failure #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcheemaa merged 2 commits into from
Apr 5, 2026
Merged

fix: skip SSH agent when no keys loaded to prevent auth failure #12

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abd9674
fix: skip SSH agent when no keys loaded to prevent auth failure
mcheemaa Apr 5, 2026
3bf24bb
fix: keep agent connection open through ssh.Dial for lazy callback
mcheemaa Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions internal/hetzner/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,15 +287,22 @@ func SSHConnect(ip string) (*ssh.Client, error) {
var diagErrors []string

// Try SSH agent first (handles passphrase-protected keys)
var agentConn net.Conn
if sock := os.Getenv("SSH_AUTH_SOCK"); sock != "" {
conn, err := net.Dial("unix", sock)
if err != nil {
diagErrors = append(diagErrors, fmt.Sprintf("SSH agent dial failed: %v", err))
} else {
agentConn = conn
agentClient := agent.NewClient(conn)
authMethods = append(authMethods, ssh.PublicKeysCallback(agentClient.Signers))
signers, err := agentClient.Signers()
if err != nil {
diagErrors = append(diagErrors, fmt.Sprintf("SSH agent signers failed: %v", err))
conn.Close()
} else if len(signers) == 0 {
conn.Close()
} else {
authMethods = append(authMethods, ssh.PublicKeysCallback(agentClient.Signers))
conn.Close()

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep agent socket open for PublicKeysCallback auth

ssh.PublicKeysCallback(agentClient.Signers) is lazy and runs during ssh.Dial, but this change closes conn immediately afterward, so the callback has no live agent transport when authentication actually starts. In environments that rely on agent-backed keys (for example passphrase-protected keys that cannot be parsed from ~/.ssh/id_*), agent auth now fails deterministically even when keys are loaded, which regresses the main SSH path this function is meant to support.

Useful? React with 👍 / 👎.

}
}
}

Expand All @@ -314,7 +321,7 @@ func SSHConnect(ip string) (*ssh.Client, error) {
if err != nil {
var passErr *ssh.PassphraseMissingError
if errors.As(err, &passErr) {
continue // passphrase-protected, skip — agent handles these
continue // passphrase-protected, skip - agent handles these
}
diagErrors = append(diagErrors, fmt.Sprintf("failed to parse %s: %v", keyPath, err))
continue
Expand All @@ -340,9 +347,6 @@ func SSHConnect(ip string) (*ssh.Client, error) {

client, err := ssh.Dial("tcp", ip+":22", config)
if err != nil {
if agentConn != nil {
agentConn.Close()
}
return nil, err
}
return client, nil
Expand Down
Loading