Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelerators to page/extension menus #1425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugenesvk
Copy link

@eugenesvk eugenesvk commented Apr 4, 2024

Also added a few icons for much faster visual differentiation between the options

  • 📝 Annotate and save the page
  • Annotate and save the page

By the way, do you know how to force those text icons to be in place of actual icons in the menus (there is a dedicated column for them left of text, this would solve the misalignment issue)?

I'd gone with the tradition of adding accelerators to the matching letters within the name if found, but honestly I'd just move all of them to the left just like for &D Save selection" since it's (to me) more important to see the shortcut right away, and those tiny underscores in the middle of sentences aren't very functional even if looking nicer

Another downside is that the extension menu has those ugly & marks not removed in some browsers (not in Chrome, though), and even with them the accelerators seem to work, but that's on browsers

I'd also rename the extension to &SingleFile just for this :) but that's maybe going too far, will just do it locally (though would be nice to find a way to somehow make it user configurable not to do ugly local patches)

(moved items around to match the menu order to make keeping track of the shortcuts/edits easier)

Partially addresses #1420

also add icons for faster visual differentiation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants