Skip to content

[mach] Make section_by_name support loading sections starting with dot #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipc merged 1 commit into from
May 31, 2019
Merged

[mach] Make section_by_name support loading sections starting with dot #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/macho.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,20 +130,15 @@ where
fn section_by_name(&'file self, section_name: &str) -> Option<MachOSection<'data, 'file>> {
// Translate the "." prefix to the "__" prefix used by OSX/Mach-O, eg
// ".debug_info" to "__debug_info".
let (system_section, section_name) = if section_name.starts_with('.') {
(true, &section_name[1..])
} else {
(false, section_name)
};
let system_section = section_name.starts_with('.');
let cmp_section_name = |section: &MachOSection| {
section
.name()
.map(|name| {
if system_section {
name.starts_with("__") && section_name == &name[2..]
} else {
section_name == name
}
section_name == name
|| (system_section
&& name.starts_with("__")
&& &section_name[1..] == &name[2..])
})
.unwrap_or(false)
};
Expand Down