Skip to content
Open

V2 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
cb21701
ok it can be compiled
ginpei Jan 6, 2019
61002e1
available in example pages
ginpei Jan 7, 2019
a1846bd
enable tests
ginpei Jan 7, 2019
a505150
better dev exp
ginpei Jan 8, 2019
eb30f6e
prever protected to private
ginpei Jan 8, 2019
9e788fe
remove DOM window requirement
ginpei Jan 8, 2019
5b620f9
now use the name
ginpei Jan 8, 2019
ccfe4ff
make sure out dir has only target files
ginpei Jan 8, 2019
2409089
sort out package.json, adding main field
ginpei Jan 8, 2019
415c897
lint
ginpei Jan 8, 2019
e9de7d2
build for both import and download
ginpei Jan 9, 2019
c593154
html5-youtube.min.js
ginpei Jan 9, 2019
6f722f3
replace tabs with spaces
ginpei Jan 9, 2019
f5f05dc
follow changes in webpack settings
ginpei Jan 9, 2019
8e915f2
tidy up out dir
ginpei Jan 11, 2019
0949ef8
allow putting notes
ginpei Jan 11, 2019
264a2c4
remove old scripts
ginpei Jan 12, 2019
41df4c4
reference DOM's setTimeout
ginpei Jan 12, 2019
4aeb56a
replace testem with jest
ginpei Jan 12, 2019
4a444d9
obvious name
ginpei Jan 12, 2019
4f614f6
wrap whole tests in a big description
ginpei Jan 12, 2019
6ec75e2
correct words
ginpei Jan 13, 2019
faa1040
updated by npm
ginpei Jan 13, 2019
efc226c
move methods to private
ginpei Jan 13, 2019
c2b6d6e
follow renamed file
ginpei Jan 13, 2019
c4ed4b9
comments
ginpei Jan 13, 2019
e9dac6e
watch script
ginpei Jan 13, 2019
a8937bf
explicitly public getters and setters
ginpei Jan 13, 2019
5eb0d4a
remove underscores from interfaces
ginpei Jan 13, 2019
a845310
comments
ginpei Jan 13, 2019
ccf3ada
travis
ginpei Jan 13, 2019
fd6e7d4
travis badge
ginpei Jan 13, 2019
96c7442
code climate
ginpei Jan 13, 2019
fb2aab4
prettier
ginpei Jan 13, 2019
9121b0a
respect comment
ginpei Jan 13, 2019
9842337
follow original options interface
ginpei Jan 13, 2019
a982e8f
updated by npm
ginpei Jan 14, 2019
359f993
use new interfaces
ginpei Jan 14, 2019
e09f1ca
extract functions to load YouTube API
ginpei Jan 14, 2019
62b3e74
replace own event emitter with the famous package
ginpei Jan 15, 2019
96b0ddf
added npm badge (unofficial)
ginpei Jan 15, 2019
1ef74cc
shallow stack
ginpei Jan 15, 2019
dcbf17e
event types
ginpei Jan 15, 2019
f41f9f5
comments
ginpei Jan 15, 2019
b9c5705
respect enum provided by @types
ginpei Jan 15, 2019
f2b449e
describe includes only tests
ginpei Jan 15, 2019
1dfaaf9
unused var
ginpei Jan 15, 2019
36a9b6c
reduce var with big scope
ginpei Jan 15, 2019
ed7e872
ignore coverage
ginpei Jan 15, 2019
d7d1b1e
refactor options
ginpei Jan 15, 2019
f4044e4
remove duplicated tests
ginpei Jan 15, 2019
1f279d7
separate video ID and URL
ginpei Jan 16, 2019
776338c
add test
ginpei Jan 16, 2019
ff3f71d
remove IE version
ginpei Jan 16, 2019
edf08e0
comments
ginpei Jan 16, 2019
ed78739
extract event functions
ginpei Jan 16, 2019
0c98fb8
split youtube wrapper and HTML5 wrapper
ginpei Jan 16, 2019
c1aefb6
separate web resouces
ginpei Jan 17, 2019
0041fe5
remove unused packages
ginpei Jan 18, 2019
858b994
review npm scripts
ginpei Jan 18, 2019
2cb34fc
review ts config
ginpei Jan 18, 2019
e0118e5
enable strict type-checking options
ginpei Jan 18, 2019
33eb5c9
upgrade typescript
ginpei Jan 18, 2019
2b32fb1
tests in strict mode
ginpei Jan 18, 2019
36063f0
avoid type error in VS Code
ginpei Jan 27, 2019
170da09
respect default confit file
ginpei Jan 27, 2019
116e24c
cosmetics
ginpei Jan 27, 2019
75ace5d
comments
ginpei Jan 27, 2019
ed5a0eb
player values
ginpei Jan 27, 2019
c18d434
comments
ginpei Jan 27, 2019
521e1cf
more reasonable order
ginpei Jan 27, 2019
597c38b
comment
ginpei Jan 28, 2019
66aea31
arrange
ginpei Jan 28, 2019
96656dc
coverage
ginpei Feb 21, 2019
2750b4a
upgrade jest and ts-jest
ginpei Mar 12, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
exclude_patterns:
- "**/*.test.ts"
13 changes: 6 additions & 7 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
# editorconfig.org
root = true

[*]
indent_size = 2
indent_style = space
end_of_line = lf
charset = utf-8
indent_style = tab
indent_size = 2
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
indent_style = space
indent_size = 4

[package.json]
indent_style = space
trim_trailing_whitespace = false
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
.,*
node_modules
examples/video.mp4
out
coverage
3 changes: 3 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/.vscode/settings.json
/out/test.*
/out/web.*
11 changes: 11 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
language: node_js
node_js:
- "10"
before_script:
- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
- chmod +x ./cc-test-reporter
- ./cc-test-reporter before-build
script:
- npm test -- --coverage
after_script:
- ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ Note: "youtube.js" has been renamed "html5-youtube.js".

# html5-youtube.js

[![NPM](https://nodei.co/npm/html5-youtube.png)](https://nodei.co/npm/html5-youtube/)

<!-- TODO change branch to master -->
[![Build Status](https://travis-ci.org/ginpei/html5-youtube.js.svg?branch=v2)](https://travis-ci.org/ginpei/html5-youtube.js)
[![Maintainability](https://api.codeclimate.com/v1/badges/cd4a8c29404801838810/maintainability)](https://codeclimate.com/github/ginpei/html5-youtube.js/maintainability)

YouTube Player API wrapper like HTML5 video API.

* [YouTube Player API Reference for iframe Embeds - YouTube — Google Developers](https://developers.google.com/youtube/iframe_api_reference)
Expand Down
4 changes: 2 additions & 2 deletions examples/basic.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
<body>
<h1>html5-youtube.js</h1>
<div id="my-youtube-player" data-youtube-videoid="KFstP0C9sVk"></div>
<script src="../html5-youtube.js"></script>
<script src="../out/web/html5-youtube.js"></script>
<script>
var elPlayer = document.getElementById('my-youtube-player');

youtube({ el:elPlayer });
const player = new Html5YouTube(elPlayer);
</script>
</body>
</html>
157 changes: 0 additions & 157 deletions examples/full-player.compat.html

This file was deleted.

10 changes: 5 additions & 5 deletions examples/full-player.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h1>html5-youtube.js</h1>
<br />
<label><input class="js-logging" type="checkbox" checked />Log all events in console</label>
</div>
<script src="../html5-youtube.js"></script>
<script src="../out/web/html5-youtube.js"></script>
<script>
(function() {
var elPlayer = document.querySelector('.js-player');
Expand All @@ -59,7 +59,7 @@ <h1>html5-youtube.js</h1>
this.innerHTML = text;
};

var player = window.player = youtube({ el:elPlayer });
var player = window.player = new Html5YouTube(elPlayer);

player.addEventListener('canplay', function(event) {
elVideos.disabled = false;
Expand All @@ -75,7 +75,7 @@ <h1>html5-youtube.js</h1>
elCurrentTimeText.setTime(player.currentTime);
elVolume.checked = player.muted;
elVolume.value = player.volume;
elPlaybackRate.value = youtube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRate.value = Html5YouTube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRateText.innerHTML = player.playbackRate;
});
player.addEventListener('play', function(event) {
Expand Down Expand Up @@ -103,7 +103,7 @@ <h1>html5-youtube.js</h1>
elVolume.value = player.volume;
});
player.addEventListener('ratechange', function(event) {
elPlaybackRate.value = youtube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRate.value = Html5YouTube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRateText.innerHTML = player.playbackRate;
});
player.addEventListener('error', function(event) {
Expand Down Expand Up @@ -150,7 +150,7 @@ <h1>html5-youtube.js</h1>
player.volume = this.value;
});
elPlaybackRate.addEventListener('change', function(event) {
player.playbackRate = youtube.availablePlaybackRates[this.value];
player.playbackRate = Html5YouTube.availablePlaybackRates[this.value];
});
})();
</script>
Expand Down
12 changes: 6 additions & 6 deletions examples/html5video.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8">
<title>HTML5 &lt;video&gt;</title>
<title>HTML5 &lt;video&gt; (to compare)</title>
<style>
.player {
height: 300px;
Expand All @@ -11,7 +11,7 @@
</style>
</head>
<body>
<h1>HTML5 &lt;video&gt;</h1>
<h1>HTML5 &lt;video&gt; (to compare)</h1>
<p>
<em>This is the demo of HTML5 video, not html5-youtube.js.</em>
Before run, you have to download video file using this command:
Expand Down Expand Up @@ -43,7 +43,7 @@ <h1>HTML5 &lt;video&gt;</h1>
</div>
<script>
(function() {
var youtube = {
var Html5YouTube = {
availablePlaybackRates: [0.25, 0.5, 1, 1.5, 2]
};

Expand Down Expand Up @@ -85,7 +85,7 @@ <h1>HTML5 &lt;video&gt;</h1>
elCurrentTimeText.setTime(player.currentTime);
elVolume.checked = player.muted;
elVolume.value = player.volume;
elPlaybackRate.value = youtube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRate.value = Html5YouTube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRateText.innerHTML = player.playbackRate;
});
player.addEventListener('play', function(event) {
Expand Down Expand Up @@ -113,7 +113,7 @@ <h1>HTML5 &lt;video&gt;</h1>
elVolume.value = player.volume;
});
player.addEventListener('ratechange', function(event) {
elPlaybackRate.value = youtube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRate.value = Html5YouTube.availablePlaybackRates.indexOf(player.playbackRate);
elPlaybackRateText.innerHTML = player.playbackRate;
});
player.addEventListener('error', function(event) {
Expand Down Expand Up @@ -160,7 +160,7 @@ <h1>HTML5 &lt;video&gt;</h1>
player.volume = this.value;
});
elPlaybackRate.addEventListener('change', function(event) {
player.playbackRate = youtube.availablePlaybackRates[this.value];
player.playbackRate = Html5YouTube.availablePlaybackRates[this.value];
});

player.src = videoId;
Expand Down
4 changes: 2 additions & 2 deletions examples/player.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ <h1>html5-youtube.js</h1>
<button class="js-play" disabled>Play</button>
<button class="js-pause" disabled>Pause</button>
</div>
<script src="../html5-youtube.js"></script>
<script src="../out/web/html5-youtube.js"></script>
<script>
(function() {
var elPlayer = document.querySelector('.js-player');
var elPlay = document.querySelector('.js-play');
var elPause = document.querySelector('.js-pause');
var videoId = 'KFstP0C9sVk';

var player = youtube({ el:elPlayer, id:videoId })
var player = new Html5YouTube(elPlayer, { videoId })
.on('ready', function(event) {
player.play();
})
Expand Down
Loading